Skip to content

Fix a broken UI on search for results in some cases

Takuya Noguchi requested to merge 934-search-ui into master

Why

UI is weirdly broken on search for results with some query: e.g., cicd pipeline commands.

What

Fixes:

  • a broken UI on search for results in some cases, introduced in !1310 (merged)
  • indentations in layout HAML

Screenshots with clickable links to the production/review apps

Query Device Type Before After Note
?q=cicd%20pipeline%20commands PC docs.gitlab.com_search__q_cicd_20pipeline_20commands_iPad_Pro_ 3004-fc060365-79ee-4bba-ab97-bcb5913fb9ab.ws-us03.gitpod.io_search__q_cicd_20pipeline_20commands_iPad_Pro_
?q=cicd%20pipeline%20commands mobile docs.gitlab.com_search__q_cicd_20pipeline_20commands_iPhone_X_ 3004-fc060365-79ee-4bba-ab97-bcb5913fb9ab.ws-us03.gitpod.io_search__q_cicd_20pipeline_20commands_iPhone_X_
?q=nothingnothing PC (skipped since just confirming if there is no regression; link) 3004-fc060365-79ee-4bba-ab97-bcb5913fb9ab.ws-us03.gitpod.io_search__q_nothingnothing_iPad_Pro_
?q=nothingnothing mobile (skipped since just confirming if there is no regression; link) 3004-fc060365-79ee-4bba-ab97-bcb5913fb9ab.ws-us03.gitpod.io_search__q_nothingnothing_iPhone_X_

Closes #934 (closed)

Edited by Takuya Noguchi

Merge request reports