Skip to content

Mostly adequate docsite typescale update

David O'Regan requested to merge 300424-typescale into master

The mostly adequate GitLab docs site type scale redo.

This merge request serves as the smallest (yes David, a + 2878 diff is small isn't it?) possible MVC where we look to update the GitLab documentation website to use the new type scale.

The DDoD for this update is:

Page Renders Correctly
Home
Default
Archives
404
Search

NB

The 404 page needs a facelift.

Visual

Page Before After
Home Screenshot_2021-05-07_at_17.36.55 Screenshot_2021-05-07_at_17.38.24
Default Screenshot_2021-05-07_at_17.37.00 Screenshot_2021-05-07_at_17.38.28
Archives Screenshot_2021-05-07_at_17.37.06 Screenshot_2021-05-07_at_17.38.34
404 Screenshot_2021-05-07_at_17.37.21 Screenshot_2021-05-07_at_17.38.51
Search Screenshot_2021-05-07_at_17.37.12 Screenshot_2021-05-07_at_17.38.40

In order to achieve this update, we are at the core of replacing the majority of CSS for the site. While normally I aim to write very small, concise MVC's, I don't see a better way forward for this. Given that, we need to be sure this "MVC" is perfect before we merge.

How to test

  1. Before: https://docs.gitlab.com/ee/development/documentation/styleguide/

  2. After: http://300424-typescale.178.62.207.141.nip.io/ee/development/documentation/styleguide/#documentation-style-guide

References

Edited by Susan Tacker

Merge request reports

Loading