Skip to content

Skip adding external domains to Pages redirects

Achilleas Pipinellis - OOO until November 25th (parental leave) requested to merge axil-dont-add-external-domain-redirects into main

Fix an edge case of redirects #1157 (comment 909723131).

The docs:clean_redirects task was adding external domains to redirects.yaml, but this is not yet supported by Pages redirects https://docs.gitlab.com/ee/user/project/pages/redirects.html

To test locally:

  1. Comment out all the git commands from the task
  2. Edit gitlab/doc/push_rules/push_rules.md to include an external site under redirect_to.
  3. Change the date to be less than today
  4. Run the task bin/rake docs:clean_redirects

The file should be deleted, but an entry not added in redirects.yaml.

_We should write some proper tests instead of this, but it will do for now 😄

Closes #1157 (closed)

Edited by Achilleas Pipinellis - OOO until November 25th (parental leave)

Merge request reports