Skip to content

Revert "Merge branch 'renovate/major-nodejs-dependencies' into 'main'"

Sarah German requested to merge revert-8dc1417d into main

What does this MR do and why?

Reverts !3093 (merged). This caused some errors in the JavaScript build process and with the search page at /search (link).

Screenshots, screen recordings, or links to review app

Before revert After revert
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md.
  2. Run yarn and yarn bundle. You should not see errors like this on the revert-8dc1417d branch:
content/frontend/search/instantsearch.js → public/frontend/search/instantsearch.js...
(!) Missing shims for Node.js built-ins
Creating a browser bundle that depends on "http", "https" and "url". You might need to include https://github.com/FredKSchott/rollup-plugin-polyfill-node
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
https (imported by https?commonjs-external)
http (imported by http?commonjs-external)
url (imported by url?commonjs-external)
crypto (imported by crypto?commonjs-external)
(!) Missing global variable names
Use output.globals to specify browser global variable names corresponding to external modules
crypto (guessing 'require$$3')
http (guessing 'require$$0')
https (guessing 'require$$1')
url (guessing 'require$$2')
created public/frontend/search/instantsearch.js in 6.2s

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sarah German

Merge request reports

Loading