Prevent the search keyboard shortcut from opening "Quick Find" in Firefox
What does this MR do and why?
The /
key is used as a keyboard shortcut to the search box. However, in Firefox, this opens the "Quick Find" widget in the browser.
Instead, this should focus on the search box like it does in other browsers. This behavior is the same as global search in the GitLab product.
Screenshots, screen recordings, or links to review app
Review app: https://gps-kbd-search-firefox.docs.gitlab-review.app/
before | after |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md. -
Check out this branch -
Recompile the site and start the local web server ( make view
) -
In Firefox, verify you can use the /
key to focus on the search box (same behavior as gitlab.com) -
Verify the keyboard shortcut also works in Chrome, Safari and Edge
Merge request acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this merge request.
Edited by Sarah German