Add Make to documentation Markdown linting image
What does this MR do and why?
Because we removed build-base
package (https://pkgs.alpinelinux.org/package/v3.19/main/x86_64/build-base) in: !4702 (merged), we lost make
.
I think it was good to not add development tools to an image that shouldn't need to compile anything, but we do need make
.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md. -
Check out this branch. -
Run docker buildx build --file dockerfiles/gitlab-docs-lint-markdown.Dockerfile . --platform=linux/amd64 --build-arg="ALPINE_VERSION=3.19" --build-arg="VALE_VERSION=3.4.1" --build-arg="MARKDOWNLINT2_VERSION=0.13.0" --build-arg="LYCHEE_VERSION=0.14.3"
-
Run docker run --rm -it --platform=linux/amd64 <Docker image SHA> bash
-
In the running container, run make --version
.
Merge request acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this merge request.
Edited by Evan Read