Skip to content

feat: add an option to control disks mounting behaviour

Muhamed Huseinbašić requested to merge mhdisks into main

What does this MR do?

This MR is adding the option to control additional disks mounting behaviour, as exposed by Ansible:

https://docs.ansible.com/ansible/latest/collections/ansible/posix/mount_module.html#parameter-state

Default remains as it is, but gives users the option to manipulate this setting in case of migrations and similar times.

Related issues

related issue Add an option to control disks mounting behaviour (#728 - closed), and discussion in Slack related to this feature:

https://gitlab.slack.com/archives/C01DE8TA545/p1691490368879029

Testing

This code has been tested in sample Dedicated environment with the following cases:

  1. New option was not set at all. It is confirmed that default option is used, mounting happens as soon as Ansible finishes.
  2. New option was set to present. It is confirmed that entry in /etc/fstab was created, but mounting did not happen until restart.

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Kassandra Svoboda

Merge request reports

Loading