Skip to content

Add AZ ignore config for AWS Data Disks

Grant Young requested to merge gy-aws-data-disk-az-ignore into main

What does this MR do?

MR updates ignore_changes config for AWS Data Disks to include availability_zone.

Due to the set up of AWS disks, the disk must be placed in the same Availability Zone as the intended VM. However with VMs requiring a Subnet that usually supersedes AZ so this leads to a syncing challenge, which to get around we set the disks to follow their intended VM's availability_zone value

One of these challenges is around this linking. By creating said link this means when the VM is to be removed for any reason so now will the disk in Terraform logic. By adding this config this breaks that link to ensure the disk remains for DR scenarios such as replacing the VM but wanting to keep the disk and data. Further details about this can be seen here.

Note this is only a consideration for AWS and it's particular network setup. GCP is unaffected.

Related issues

Closes #866 (closed)

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Grant Young

Merge request reports

Loading