Skip to content

Disable registry in Sidekiq chart

Nailia Iskhakova requested to merge disable-registry-in-sidekiq into main

What does this MR do?

MR disables registry in Sidekiq chart when the main Registry chart is disabled. Otherwise Hybrid environments that don't have registry set up are stung by the bug when project is not deleted due to Failed to open TCP connection to gitlab-registry.default.svc:5000 , more details in gitlab#343921 (comment 729663870) and gitlab#24110 (comment 729703160). The workaround is to disable registry in Sidekiq chart until gitlab#24110 is closed.

Related issues

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: setup a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Nailia Iskhakova

Merge request reports

Loading