Fixes for latest Ansible Lint
What does this MR do?
MR updates for latest version of Ansible Lint rules:
-
no-free-form
Avoid using free-form when calling module actions - Numerous good reasons give. Adjusted tasks to follow -
yaml[octal-values]
Forbidden implicit octal value - YAML quirk. Switched to strings for Octals. -
ignore-errors
Use failed_when and specify error conditions instead of using ignore_errors - Bit subjective but the principle is fair, adjusted and will monitor.
The following rules were disabled:
-
key-order[task]
task key order to: name, when, block` - Optional / subjective in Ansible. -
galaxy[no-runtime]
Collection runtime config file missing - Optional in Ansible, we don't release to Galaxy due to License.
Author's checklist
When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers
:
- Merge request:
-
Corresponding Issue raised and reviewed by the GET maintainers team. -
Merge Request Title and Description are up-to-date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline -
MR has no new security alerts in the widget from the Secret Detection
andIaC Scan (SAST)
jobs.
-
- Code:
-
Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.). -
Documentation created/updated in the same MR. -
If this MR adds an optional configuration - check that all permutations continue to work. -
For Terraform changes: set up a previous version environment, then run a terraform plan
with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
-
-
Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Grant Young