Skip to content

Fix a 500 error on the tree content view with an empty readme file

Baldinof requested to merge baldinof/gitlab-ce:fix-empty-readme into master

What does this MR do?

It hides the readme block on tree view if the readme file is empty.

Are there points in the code the reviewer needs to double check?

Maybe we should show the empty placeholder if the readme file is empty.

Why was this MR needed?

On master, a 500 error is thrown on tree view pages if the readme file is empty. On GitLab.com the block is shown but empty.

Screenshots (if relevant)

With this MR Hidden empty readme

Currently on GitLab.com Empty readme on GitLab.com

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports

Loading