Skip to content

Update task_list to version 2.0.0

Jared Deckard requested to merge deckar01/gitlab-ce:task-list-2 into master

What does this MR do?

  • Updates the task_list library to 2.0.0
  • Manages the javascript asset of task_list using yarn
  • Removes the manually patched vendor script for task_list

Are there points in the code the reviewer needs to double check?

It might be necessary to perform a security review of both the gem contents and the npm package since they are not in the diff.

Why was this MR needed?

we have a patched version of your library and it will be pain in the ass if we want to update it later.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6837#note_16967841

task_list.js was tracked as a vendor script that had to be patched manually. This new version is published to npm and avoids the need for manual updated by making jQuery optional.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #22470 (closed)

Edited by Jared Deckard

Merge request reports

Loading