Don't expand CI_ENVIRONMENT_URL so runner would do
What does this MR do?
Don't expand CI_ENVIRONMENT_URL so runner would do
Are there points in the code the reviewer needs to double check?
The behaviour is somehow tricky to grasp... this is not intuitive.
- Why
CI_ENVIRONMENT_URL
should be the last variable? - Why we have
expanded_environment_url
yet we're not using it inpersisted_environment_variables
?
At least we have tests though. I'll add a few more comments.
Why was this MR needed?
So that CI_ENVIRONMENT_URL
could be expanded by runners, instead of expanding it in Ruby, which is somehow tricky to avoid mutual recursion. See !12333 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
Added for this feature/bug
-
What are the relevant issue numbers?
Closes #34008 (closed)
Edited by Lin Jen-Shin