Skip to content

Adds requirements that supports anything in sha params

Guilherme Vieira requested to merge gvieira37/gitlab-ce:sha-handling into master

What does this MR do?

Fix the 404 error in API when the branch has a dot in its name as stated in #26561 (closed) and in #2709 (closed).

Why was this MR needed?

Since we use Grape gem, every param we define for a given endpoint is restricted to a default format. This default format does not allow dots in value, so whenever we have a :sha param we are going to explicitly allow any kind of text for it to work. This has been already done for some endpoints, so I just replicated the strategy for the other cases.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #26561 (closed), #2709 (closed)

Edited by Lin Jen-Shin

Merge request reports

Loading