Improve sprite icon spec (!14914) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Clement Ho requested to merge improve-sprite-icon-spec into master Oct 17, 2017

What does this MR do?

Improve sprite icon spec by

Moving spriteIcon describe block out of ajaxPost describe block
Use imported spriteIcon rather than using gl.utils.spriteIcon
Cache gon before overriding it so that we can revert to original state and not pollute other tests

Are there points in the code the reviewer needs to double check?

Shouldn't be

Why was this MR needed?

~"technical debt"

Screenshots (if relevant)

None

Does this MR meet the acceptance criteria?

Review
- Has been reviewed by Frontend

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39199