Skip to content

Resolve "Merge request widget - CI information has different margins"

Filipa Lacerda requested to merge 38395-mr-widget-ci into master

What does this MR do?

  1. Fixes the bug: Moves the graph to the end of the sentence.
  2. Fixes technical debt:
  3. Moves the file into a .vue file
  4. Removes a lot of HTML elements not needed, improving performance since DOM needs less watchers
  5. Removes the all store from the component, making it more easy to reuse and improving performance since it has less watcher
  6. Cleans tests: Some test were testing vue itself, other where testing all inside the same it making it hard to maintain. Each rendered output is now inside it's own it block and only rendered output and more complex computed props are being tested.

Screenshots (if relevant)

Screen_Shot_2017-11-07_at_00.22.22 Screen_Shot_2017-11-07_at_00.12.08

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #38395 (closed)

Merge request reports

Loading