Skip to content

Fail when issuable_meta_data is called on an unlimited collection

Sean McGivern requested to merge fix-issues-api-list-performance into master

What does this MR do?

Fix a performance problem with the issues API, where we were loading metadata for the un-paginated collection.

Are there points in the code the reviewer needs to double check?

The condition in Gitlab::IssuableMetadata#issuable_meta_data could maybe be clearer?

Why was this MR needed?

We were trying to load metadata for all of a project's (or group's) issues, even when only getting a page's worth of issues 🤦

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39845.

Merge request reports

Loading