When a custom header logo is present, don't show GitLab type logo
What does this MR do?
In the new navigation header, when a user uploads a custom header logo GitLab will still show the 'GitLab' type logo. This is often undesirable as the user may want to upload a logo with their own name present. This change will toggle the GitLab type logo if a custom header logo is present.
The problem was brought up in #ux chat. I got a wild hair so I decided to go see if I could find a workable solution quickly.
Are there points in the code the reviewer needs to double check?
I changed the help text on the appearances form page. It used to say the pages were optimized for 72x72 logos. The logo in the header is set to 28px height so I think that's a more appropriate value here, but I'm not 100% sure if there's some other reason that we may want to say 72px.
Screenshots (if relevant)
Before:
After:
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered