Skip to content

HTTPS only Pages

Rob Watson requested to merge rfwatson/gitlab-ce:pages_force_https into master

What does this MR do?

Add the option of forcing GitLab Pages HTTP traffic to HTTPS, as set out in https://gitlab.com/gitlab-org/gitlab-ce/issues/28857.

Dependent on: gitlab-pages!50 (merged). Marking as WIP while this remains open.

CI

All jobs passing except ee_compat_check. The conflicts look trivial, but I believe that I can't make this job pass without access to gitlab-ee repo?

Testing locally

To test locally you will need:

  • GitLab Runner service active, with Docker executor available
  • GitLab Pages server compiled from this branch and running

Happy to add more detailed steps if they would be helpful to anybody.

Are there points in the code the reviewer needs to double check?

None known.

Why was this MR needed?

Closes #28857 (closed).

Screenshot

Screenshot_2018-01-06_21-59-56

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#28857 (closed)

Edited by Rob Watson

Merge request reports

Loading