Skip to content

Use an at_exit hook to stop test gitaly

Jacob Vosmaer requested to merge stop-gitaly-atexit into master

What does this MR do?

Use an at_exit hook instead of 'after suite' to stop the Gitaly process spawned during Rspec tests.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Although we don't understand exactly how, it's possible for Rspec processes to be terminated in a way where Rspec does not get to terminate its Gitaly helper process. We hope this hook might be more robust.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/41991

Edited by Jacob Vosmaer

Merge request reports

Loading