Skip to content

Unify deployment_platform interface with EE

Lin Jen-Shin requested to merge consistent-deployment_platform into master

What does this MR do?

Unify deployment_platform interface with EE

EE: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4875

Why was this MR needed?

We're not using the argument in CE, but we do override the method and use the argument. We should keep the method interface the same, otherwise it's easy to get confused or get something wrong.

What are the relevant issue numbers?

Discovered in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4869 and https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/56163575

@jameslopez We might want to pick this for 10.6 too.

Edited by Lin Jen-Shin

Merge request reports

Loading