Resolve "Calculating total size of a project's CI artifacts"
What does this MR do?
At the moment the total artifacts size is calculated in a background worker by summing a bunch of rows in builds
and job_artifacts
but this calculation is very slow and times out. So we've changed the implementation to keep the column up to date by incrementing/decrementing whenever a change occurs rather re-summing every time a change occurs.
This was originally described in the issue comments https://gitlab.com/gitlab-org/gitlab-ce/issues/41059#note_55173963
Are there points in the code the reviewer needs to double check?
Also see EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5157
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - [-] Documentation created/updated
- [-] API support added
-
Tests added for this feature/bug - Review
- [-] Has been reviewed by UX
- [-] Has been reviewed by Frontend
-
Has been reviewed by Backend -
Has been reviewed by Database
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together - [-] Internationalization required/considered
-
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #41059 (closed)
Edited by Yorick Peterse