WIP: Group Runner Can Be Added From Group > Settings > CI/CD
TODO
-
Allow show,edit,pause,resume,destroy of group runner -
Keep runner setup instructions around after adding runner
What does this MR do?
Moves the group runner setup to group settings and adds link to this from project settings
Are there points in the code the reviewer needs to double check?
-
Will we have conflicts with new routes for group runners (eg. subgroups might cause an issue?) -
edit_group_runner_path -
group_runner_path -
resume_group_runner_path -
pause_group_runner_path
-
-
Is can?(current_user, :admin_pipeline, group)
appropriate for pause,resume,edit runner? -
Do we need specs for Groups::RunnersController
where we test the security?
Why was this MR needed?
Screenshots (if relevant)
group CI/CD settings before adding runner
group CI/CD settings after adding runner
project CI/CD settings before adding group runner
project CI/CD settings after adding group runner
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Edited by Kamil Trzciński (Back 2025-01-01)