Skip to content

Add signature verification badge to compare view

Marc requested to merge marcshaw/gitlab-ce:44879 into master

What does this MR do?

Attaches a signature verification badge to a commit (when one is signed) on the revision comparison view.

Are there points in the code the reviewer needs to double check?

The specs I added in compare_controller_spec.rb could have been done better, but I do not know the code base well enough to know if I am missing any helpers or such. Any suggestions would be appreciated.

Why was this MR needed?

Issue: #20268 (closed) introduced showing to the user when a commit is signed. It seems like the view fixed in the current change was overlooked during the previous issue.

Screenshots (if relevant)

Before Screen_Shot_2018-04-08_at_9.14.58_PM After Screen_Shot_2018-04-08_at_9.15.35_PM

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#44879 (closed)

Edited by Inactive Account

Merge request reports

Loading