Skip to content

Fix: Use case in-sensitive ordering by name for groups

Harish Ved requested to merge vedharish/gitlab-ce:order_groups into master

What does this MR do?

Makes the order for groups listing by name on the dashboard for /dashboard/groups?sort=name_asc case-insensitive

Are there points in the code the reviewer needs to double check?

  • Current behaviour for /projects?sort=name_asc is also case-sensitive ie. follows the order AA BB CC aa bb cc
  • Should the fix instead be for name column for all entities that include Sortable instead? ie. here
  • This is my first MR to gitlab-ce. Please check if I wrongly marked any of the acceptance criteria as [n/a]

Why was this MR needed?

As a fix for the open issue

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #45617

Screenshots for sorting groups after this patch

sorted_by_name_asc

sorting_by_name_asc

sorted_by_name_desc

sorting_by_name_desc

sorted_by_last_created

sorting_by_last_created

Edited by Rémy Coutable

Merge request reports

Loading