Optimize `with_artifacts_archive` scope on Ci::Build
What does this MR do?
Optimize with_artifacts_archive
scope on Ci::Build to not do a subquery but a LEFT JOIN
.
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
The current query times out on a run of the gitlab:artifacts:migrate
task on gstg while the new query finishes and seems be much faster.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
I bumped on this while working on https://gitlab.com/gitlab-com/migration/issues/333
Edited by Alejandro Rodríguez