Skip to content

[CE] Resolve "Extract EE specific files/lines for lib/gitlab/auth"

Rémy Coutable requested to merge 5913-extract-ee-specific-lines-for-lib-gitlab-auth into master

CE backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5761

What does this MR do?

This backport some EE-specific lines of code from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5761.

  • 1ccc9231 2018-05-18 | Minimize CE/EE difference in Gitlab::Auth::UserAuthFinders [Rémy Coutable]
  • b0d05d4d 2018-05-18 | Minimize CE/EE difference in Gitlab::Auth::Saml::User [Rémy Coutable]
  • be8488bd 2018-05-18 | Minimize CE/EE difference in Gitlab::Auth::Saml::Config [Rémy Coutable]
  • 939d786e 2018-05-18 | Minimize CE/EE difference in Gitlab::Auth::LDAP::Config [Rémy Coutable]

Are there points in the code the reviewer needs to double check?

I will add diff notes.

Does this MR meet the acceptance criteria?

  • [-] Changelog entry added, if necessary
  • [-] Documentation created/updated
  • [-] API support added
  • [-] Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Related to #5913 (closed).

Merge request reports