Skip to content

Resolve "Blob#batch can't handle frozen string paths"

Nick Thomas requested to merge (removed):46498-do-not-modify-strings into master

What does this MR do?

Fixes runtime errors related to modifying frozen strings

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Gitaly calls return frozen strings. Some rugged calls attempt to modify strings which are the outputs of gitaly calls, with some combinations of feature flags.

Modifying the string is unnecessary, and poor form anyway in a library method, so we can just switch to sub.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #46498 (closed)

Merge request reports

Loading