Skip to content

Resolve "Keyboard shortcuts modal is broken"

Sam Beckham requested to merge 47053-keyboard-shortcuts-modal-is-broken-2 into master

What does this MR do?

Updates the keyboard shortcuts modal to use <kbd> elements and pull in all the relevant styles for them.

Are there points in the code the reviewer needs to double check?

Not particularly, it's pretty straight-forward this one. However, there's still an issue with the modal header, but this is a more global error and should be fixed separately.

Why was this MR needed?

Two reasons:

  1. The styling for this modal was broken after the bootstrap4 update.
  2. A11y is improved by using the correct elements.

Screenshots (if relevant)

localhost_3000_h5bp_html5-boilerplate

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47053 (closed)

Edited by Taurie Davis

Merge request reports

Loading