Skip to content

Fix auto_cancel_pending_pipelines check

Jan Provaznik requested to merge rails5-enum-pipeline-check into master

What does this MR do?

It fixes auto_cancel_pending_pipelines check

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

In Rails 5 auto_cancel_pending_pipelines? is not a valid method for checking whether auto_cancel_pending_pipelines is enabled or disabled. Auto-generated helper methods are only for enum values, so in this case it would be project.enabled? or project.disabled?. The problem is that these helper method are too generic and such check would be completely misleading, so rather than use project.enabled?, an explicit check == 'enabled' is used.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47834 (closed)

Merge request reports

Loading