Skip to content

Fix nil formats test

Jan Provaznik requested to merge rails5-nil-formats into master

What does this MR do?

Fixes setting of action_dispatch.request.formats in a spec.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

One of the spec files sets nil value for env varialbe action_dispatch.request.formats. Rather than setting nil value, we can delete the action_dispatch.request.formats key from env (which should be closer to real use case anyway). The reason is that in Rails 5, formats method does not set default array of formats if the env key is already set (even if set to nil).

We don't set this variable anywhere in the code (at least I didn't find it).

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47833 (closed)

Edited by Rémy Coutable

Merge request reports

Loading