Skip to content

Rails5 fix arel from in mysql_median_datetime_sql

What does this MR do?

Fix arel from usage in mysql_median_datetime_sql for rails 5. It's the same as !19340 (merged) but for mysql. Example spec that is now fixed: spec/models/cycle_analytics/review_spec.rb:28 failed with:

 1) CycleAnalytics#review when a regular merge request (that doesn't close the issue) is created and merged returns nil
     Failure/Error:
       query = arel_table
               .from(arel_table.project(Arel.sql('*')).order(arel_table[column_sym]).as(arel_table.table_name))
               .project(average([arel_table[column_sym]], 'median'))
               .where(
                 Arel::Nodes::Between.new(
                   Arel.sql("(select @row_id := @row_id + 1)"),
                   Arel::Nodes::And.new(
                     [Arel.sql('@ct/2.0'),
                      Arel.sql('@ct/2.0 + 1')]
                   )

     ArgumentError:
       wrong number of arguments (given 1, expected 0)

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Yorick Peterse

Merge request reports

Loading