Skip to content

Remove Repository#path memoization

Jacob Vosmaer requested to merge gitlab-git-dont-memoize-path into master

What does this MR do?

Removes memoization from Gitlab::Git::Repository#path. This causes some 'disk access violations' that I had to fix.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

We don't want any (non-test) code to rely on Repository#path. This memoization was fooling our checks that detect path access.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Jacob Vosmaer

Merge request reports

Loading