Skip to content

Resolve "Improve performance of MR Changes tab: reduce event listeners on scroll event"

Filipa Lacerda requested to merge 48789-remove-event-listeners-scroll into master

What does this MR do?

Removes the scroll event listeners than handle showing the file path next to the dropdown changes. Falls back to the design before the refactor with the dropdown and the number of changes only.

  • Removes scroll event listeners being added to each file
  • Adds back the number of additions/deletions to the right top corner
  • Increases the size of the dropdown caret in the changed files dropdown

Screenshots (if relevant)

10.8 production this MR
10.8 Screen_Shot_2018-07-11_at_16.50.13 remove_scroll

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #48639 (closed) Closes #48789 (closed)

Edited by Filipa Lacerda

Merge request reports

Loading