Skip to content

Correct usage of the have_link matcher

Robert Speicher requested to merge rs-have_link-arguments into master

The second option to this matcher should be an options hash; anything else is just ignored, which can lead to false positives in tests.

We see one such false positive in the "Learn more" link test in spec/features/projects/blobs/blob_show_spec.rb.

This removes test output such as

Unused parameters passed to Capybara::Queries::SelectorQuery : ["https://rubygems.org/gems/activerecord"]
Unused parameters passed to Capybara::Queries::SelectorQuery : ["http://choosealicense.com/licenses/mit/"]
Unused parameters passed to Capybara::Queries::SelectorQuery : ["http://choosealicense.com/licenses/mit/"]
Edited by Robert Speicher

Merge request reports