Skip to content

Fix activity titles for MRs in chat notification services

Nick Thomas requested to merge (removed):fix-chat-notification-service-for-ee into master

What does this MR do?

Uses the correct title for activities generated for the chat notification services

In EE, a merge request can be approved. This triggers a chat notification, which is handled in CE code. To allow the "approved" text to make it into the notification text, an integration point is provided. However, this was not used in the activity title, causing an MR approval to be notified as "this merge request has been opened/closed" (depending on underlying MR state), instead of "approved".

This MR fixes the integration point in CE, and adds a CE-side test that ensures the integration point works.

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/5325

Does this MR meet the acceptance criteria?

Edited by Nick Thomas

Merge request reports