Renaming Secret Variables in the codebase
What does this MR do?
Secret Variables
were renamed to just Variables
in the UX (See https://gitlab.com/gitlab-org/gitlab-ce/issues/38479), but not in the codebase, which is inconsistent and may cause confusion. This was raised as an issue in https://gitlab.com/gitlab-org/gitlab-ce/issues/49629. I had free time, so I decided to attempt to correct this.
The concept of a "variable" can mean different things in the code, and naming it just variable
would make this a difficult thing to fix and could be confusing too. For simplicity, I decided to rename it "CI Variable" (ci_variable
, ci-variable
, CiVariable
) in the codebase (I now see something similar was suggested in https://gitlab.com/gitlab-org/gitlab-ce/issues/38479#note_53379435). If this MR is accepted, I'll update the docs if needed.
Ported to EE in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7964
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49629
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides