Skip to content

Move Project#rename_repo to a service class

Yorick Peterse requested to merge refactor-project-rename-repo into master

What does this MR do?

This moves the logic of Project#rename_repo and all methods only used by this method into a new service class: Projects::AfterRenameService. By moving this code into a separate service class we can more easily refactor it, and we also get rid of some RuboCop "disable" statements automatically.

During the refactoring of this code, I removed most of the explicit logging using Gitlab::AppLogger. The data that was logged would not be useful when debugging renaming issues, as it does not add any value on top of data provided by users.

I also removed a variety of comments that either mentioned something the code does in literal form, or contained various grammatical errors. Instead we now resort to more clearly named methods, removing the need for code comments.

This method was chosen based on analysis in https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue we determined this method has seen a total of 293 lines being changed in it. We also noticed that RuboCop determined the ABC size (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8028

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/release/framework/issues/28

Does this MR meet the acceptance criteria?

Edited by Yorick Peterse

Merge request reports