Skip to content

Resolve possible cherry pick API race condition

Robert Speicher requested to merge rs-cherry-pick-api into master

Previously, we just fetched the latest commit for the given branch when presenting the resulting commit, but because something could have been committed to that branch between the time we cherry-picked and the time we render the result, the wrong commit could have been presented.

Now, we fetch the commit object with the commit SHA returned by the commit change service, which should always be the correct commit.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53773

Edited by Robert Speicher

Merge request reports

Loading