[Review Apps] Don't exit when dependable job fails
What does this MR do?
The function that retrieves the dependable job is pretty basic and retrieves the first job found with the matching name, but this job can be failed but then successfully retried. In that case, we would exit the depending job even though the dependable job actually succeeded (the second time). Let's simplify things, be optimistic and continue with the depending job even if the dependable job fails.
That reverts to the original behavior.
For instance https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/147370040
failed because it was waiting for a successful gitlab:assets:compile
job
but it found https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/147322258 which
was indeed failed, but then retried and actually succeeded:
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/147342148.
Another example where review-qa-smoke
failed because it only found a
failed review-deploy
job, but this job succeeded after a retry:
https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/147372386.
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated via this MR
- [-] Tests added for this feature/bug
- [-] Tested in all supported browsers
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
-
Security reports checked/validated by reviewer