Skip to content

Fix increased package size of public/assets

Lukas Eipert requested to merge leipert-fix-webpack-bundle into master

What does this MR do?

With https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24542 gitlab:assets:compile started downloading public/assets from compile-assets. Both jobs run with different NODE_ENV leading to different build results:

  • compile-assets does not run in production mode, leading to bigger, unoptimized chunks
  • gitlab:assets:compile does run in production mode, splitting the chunks and optimizing them. If we now download the assets from compile-assets we end up with a lot of unused files, that bloat the images.

Relevant discussion: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24542/diffs#note_136961260

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Merge request reports

Loading