Use project name and ID in Review App environment URLs instead of the project path slug
What does this MR do?
This MR replaces $CI_PROJECT_PATH_SLUG
with $CI_PROJECT_ID
in the environment URL for Review Apps.
This fixes an issue where environment URLs' subdomains could exceed 63 characters, the maximum length for subdomains, primarily for projects inside multiple subgroups, causing the DNS to not to resolve. For example, take a project path GroupName/websites/websitetype/projectname
and environment name review/fix-review-app-env-url
would generate http://groupname-websites-websitetype-projectname-review-fix-review-app-env-url.autodevopsdomain.com
. The subdomain for this URL is 71 characters so it would not resolve.
Though less likely to be affected, the staging and production environment URLs are subject to this issue but are not addressed in this issue (see #52990 (closed) for more details).
What are the relevant issue numbers?
Fixes #52990 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer