Fix race condition in ApplicationSettingImplementation.create_from_defaults
What does this MR do?
Fixes a race condition in ApplicationSettingImplementation.create_from_defaults
.
This race condition could prevent Review Apps from being properly deployed/seeded.
What are the relevant issue numbers?
Closes #59162 (closed) (and potentially https://gitlab.com/gitlab-org/gitlab-ce/issues/59113 as well).
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated via this MR
- [-] Documentation reviewed by technical writer or follow-up review issue created
-
Tests added for this feature/bug - [-] Tested in all supported browsers
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
-
Security reports checked/validated by reviewer
Edited by Rémy Coutable