Add Let's Encrypt option in Pages domain new/edit Haml form
What does this MR do?
Updates the Pages domain new/edit form to include support for Let's Encrypt.
This MR is an alternative path towards an MVC for https://gitlab.com/gitlab-org/gitlab-ce/issues/28996. The other option is to rebuild the current new/edit form in Vue. This option has been explored here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26363. It is yet to be decided which option we will pursue. . The first iteration of this feature will likely be implemented in Haml. A future iteration of this feature may take on the Vue conversion effort.
UX mockups
These mockups are copied from the description of https://gitlab.com/gitlab-org/gitlab-ce/issues/28996:
Current Pages domain settings page:
MVC with automatic certificate management via Let's Encrypt
MVC with automatic certificate management disabled:
Screen recordings
Here are some recording that showcase the changes made in this MR:
With the pages_auto_ssl
feature flag disabled (the current behavior)
FeatureFlagDisabled
With the pages_auto_ssl
feature flag enabled (the new behavior)
(Sorry for the small size, this is the only way I could get it under the 10 MB limit. See #f_auto_https_renewal Slack channel (internal only) for the full-size video.)
Responsiveness demo with the pages_auto_ssl
feature flag enabled (the new behavior)
(Same comment above about the size.)
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/28996
EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/12153
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer