Designate common positioning classes as `!important` a la Bootstrap
What does this MR do?
Set the common positioning classes as !important
, like Bootstrap.
Consider the use case of SVGs in buttons: we have a global rule that sets top: 2px;
on all .btn svg
s.
In many cases, this 2px
bump is unnecessary, and we have many cases where we now have to give icons classes (most commonly .icon
), and then add CSS rules that resets top
back to 0
.
Perhaps as a intermediary step towards deciding whether that two pixel bump is required in the long term, one could simply use the prepend-top-0
class instead of icon
, and not write any duplicative CSS!
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Edited by Dennis Tang