WIP: Serialize sidekiq args - Proof of Concept
What does this MR do?
MASSIVELY INCOMPLETE MR - JUST AN IDEA FOR AN APPROACH TO TAKE
General Issue: Queueing jobs with sidekiq causes the passed arguments to be json-ified. Currently, we're working around that behavior in a variety of places & in different ways. It would be better to handle this holistically - serializing parameters in a consistent way.
Ideally, we should be able to pass ActiveRecord objects, ruby DateTime objects, Hashes, etc to delayed job workers & expect to receive comparable objects as actionable arguments, rather an a string version which needs to be otherwise manipulated.
Related Issues & MRs
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59955
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Tests added for this feature/bug -
Tested in all supported browsers -
End to end tests added if this MR has ~"Requires e2e tests" label
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team