Retry the review-deploy job twice and make the Review App cleanup more efficient
What does this MR do?
- Since we will soon disallow the
review-deploy
job to fail, we should automatically retry it twice to increase the chances to have it succeeding. - I've also realized that sometimes there was a race condition between the
kubectl delete
command and thehelm upgrade
command where thekubectl delete
command would return before the resources are actually cleaned up, resulting in a failure during the deployment:Error: release review-retry-revi-ich4bx failed: object is being deleted: persistentvolumeclaims "review-retry-revi-ich4bx-redis" already exists
. This can be seen at https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/198973681. Hopefully, using the--now --ignore-not-found --include-uninitialized
options will help resolve that.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable