Add validation for expires_at in expirable concern
What does this MR do?
Introduce the date validation for expires_at
field of the Expirable concern for both invalid and in the past date values.
Attention from @gitlab-com/gl-security/appsec is required as a new dependency to date_validator
version 0.9.0
is introduced.
Fixes #61753 (moved)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
label security
Edited by Horatiu Eugen Vlad