Use scoped routes for labels and milestones
What does this MR do?
We use group/labels.json
and group/project/labels.json
routes. However those are deprecated. We should use group/-/labels.json
and group/project/-/labels.json
instead.
Frontend code had hardcoded routes building. This MR also refactors it to use routing from backend. It ensures frontend always has correct path to resources. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29358#note_179048015 is one example why its necessary.
NOTE: Please merge EE version first => https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14104
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Dmytro Zaporozhets (DZ)