Set higher TTL to write lock for traces
What does this MR do?
Motivated from https://gitlab.com/gitlab-org/gitlab-ce/issues/60678#note_185385026.
I suspect that a concurrent Trace#archive!
access could be totally possible as long as see the ArchiveTraceWorker
's timings. If it's the case, job traces could be written by multiple processes and it could result in an unexpected outcome.
We set 10 mintues to the Exclusive Lease's TTL that archiving on new live trace architecture could take a longer than 1 minute.
This lock was originally implemented in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23332.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda